fix: handle heredocs with trailing code#25
Merged
Conversation
The heredoc tokenizer now uses a hybrid approach: - No trailing code: full token spanning opener + body + delimiter (existing behavior) - Trailing code after opener: opener-only token so the parser handles ), .method, etc. This fixes parse errors for patterns like foo(<<~SQL) and <<~HEREDOC.strip while keeping all 105 existing tests passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
foo(<<~SQL),<<~HEREDOC.strip),.method, etc.)What changed
Two files modified (
src/tokens.ts,src/syntax.grammar):tryMatchHeredocnow detects trailing code after the opener and returns either the full heredoc length or just the opener lengthTest plan
foo(<<~SQL)\n SELECT 1\nSQL— parses as MethodCall with Heredoc arg, no error nodes<<~HEREDOC.strip\n hello\nHEREDOC— parses as MethodCall chain, no error nodesa << b— still parsed as left shift, not heredocdef foo\n x = <<~SQL\n SELECT 1\n SQL\n x\nend— heredoc inside method body works